[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-535328323 Hi @rdblue , thanks for the review! I tried your idea to use `UnresovledRelation` to separate catalog and table resol

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-535377543 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-535499912 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-535757609 Hi @rdblue , thanks for your suggestion in https://github.com/apache/spark/pull/25747#discussion_r328844941 I

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-535862464 After playing with the code a bit more, I think we should write the code in a way that is future-proof. In the future

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-536152638 Hi @rdblue , let me make the problem more clear. So what you proposed is kind of ``` catalog = lookup catalog

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-536431073 retest it please This is an automated message from t

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-538298419 thanks for the review, merging to master! This is an

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-530036158 cc @brkyvz @rdblue also cc @imback82 . With this refactor, it should be much easier to refine the catalog/tab

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-531630599 Hi @rdblue , thanks for taking a look! What I want to get consensus on is the categories of v1/v2 table resolution I

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-531749580 I've updated this PR to use extractors and updated the PR description. --

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-532098408 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-532559356 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-532935452 @rdblue I agree with the behavior you posted, but like you said I don't want to mix with SPARK-29014 so I intentional

[GitHub] [spark] cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic

cloud-fan commented on issue #25747: [SPARK-29039][SQL] centralize the catalog and table lookup logic URL: https://github.com/apache/spark/pull/25747#issuecomment-533384459 @rdblue it's done. I also updated the PR description, thanks for taking a look!