[GitHub] [spark] cloud-fan commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions

cloud-fan commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-632720666 Hi @TJX2014 , the original JIRA doesn't fit this PR very well. Can you create a new JIRA ticket and update the PR title? Thanks!

[GitHub] [spark] cloud-fan commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions

cloud-fan commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-632715986 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions

cloud-fan commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-632538809 sorry it conflicts. Can you rebase? This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] cloud-fan commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions

cloud-fan commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-632049705 Let's also add some UT in `DateExpressionsSuite`, which can test both codegen and interpreted code path.

[GitHub] [spark] cloud-fan commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLIS and TIMESTAMP_MICROS functions

cloud-fan commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631935225 LGTM except https://github.com/apache/spark/pull/28534/files#r427952417 This is an automated message from the