[GitHub] [spark] cloud-fan commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

cloud-fan commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-674685602 ah it's branch-3.0 so the github action doesn't count. @HyukjinKwon how hard it is to have github action in branch-3.0?

[GitHub] [spark] cloud-fan commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

cloud-fan commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-673237590 thanks for the review, merging to 3.0! This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] cloud-fan commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

cloud-fan commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-672642993 > Is this saying the isEmpty in Sum cannot be backported to branch-3.0? I think so. 3.0 doesn't even have mechanisms to detect incompatible state store format, and it

[GitHub] [spark] cloud-fan commented on pull request #29404: [SPARK-32018][SQL][FollowUp][3.0] Throw exception on decimal value overflow of sum aggregation

cloud-fan commented on pull request #29404: URL: https://github.com/apache/spark/pull/29404#issuecomment-672601482 This adds perf overhead as we need to check overflow after each Add operation, while the master branch only checks overflow at the end because we have an extra agg buffer