[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
cloud-fan commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727818488 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-09-12 Thread GitBox
cloud-fan commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-690952463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-09-12 Thread GitBox
cloud-fan commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-690952463 > that they are different package names + same object name. This is a good point. Is it possible that we put all the error messages in the catalyst module? Other modules

[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-09-11 Thread GitBox
cloud-fan commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-690952463 > that they are different package names + same object name. This is a good point. Is it possible that we put all the error messages in the catalyst module? Other modules

[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-08-24 Thread GitBox
cloud-fan commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-679242942 I'm +1 to this idea, error message is super important to end-users, as it tells them what went wrong and how to fix it. It's easier to audit them if they are grouped together.