[GitHub] [spark] cloud-fan commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-02-09 Thread GitBox
cloud-fan commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-776412824 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] cloud-fan commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-775120028 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-01-13 Thread GitBox
cloud-fan commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-759461647 I think it's a good point that the nice usage `make_interval(hour = lit(1))` is not possible in Java. This is similar to `Dataset` APIs while Scala users can rely on implicit