[GitHub] [spark] cloud-fan commented on pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

2023-03-06 Thread via GitHub
cloud-fan commented on PR #40300: URL: https://github.com/apache/spark/pull/40300#issuecomment-1457500143 It's a good idea to provide an API that allows people to unambiguously reference metadata columns, and I like the new `Dataset.metadataColumn` function. However, I think the prepending

[GitHub] [spark] cloud-fan commented on pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

2023-03-27 Thread via GitHub
cloud-fan commented on PR #40300: URL: https://github.com/apache/spark/pull/40300#issuecomment-1485216976 about https://github.com/apache/spark/pull/40300/files#r1129818813 , I think if `SubqueryAlias` can't propagate metadata columns, then `df.metadataColumn` should not be able to get the

[GitHub] [spark] cloud-fan commented on pull request #40300: [SPARK-42683] Automatically rename conflicting metadata columns

2023-03-30 Thread via GitHub
cloud-fan commented on PR #40300: URL: https://github.com/apache/spark/pull/40300#issuecomment-1489959075 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c