[GitHub] [spark] d80tb7 commented on pull request #31399: [SPARK-34259][SQL] Don't attempt to parse file-based partitions as special timestamps

2021-02-02 Thread GitBox
d80tb7 commented on pull request #31399: URL: https://github.com/apache/spark/pull/31399#issuecomment-771471526 Hi @MaxGekk The other PR looks good to me- but just wondering where we are with this one. It looks like @cloud-fan agrees we should disallow special values being eligibl

[GitHub] [spark] d80tb7 commented on pull request #31399: [SPARK-34259][SQL] Don't attempt to parse file-based partitions as special timestamps

2021-02-02 Thread GitBox
d80tb7 commented on pull request #31399: URL: https://github.com/apache/spark/pull/31399#issuecomment-771471526 Hi @MaxGekk The other PR looks good to me- but just wondering where we are with this one. It looks like @cloud-fan agrees we should disallow special values being eligibl

[GitHub] [spark] d80tb7 commented on pull request #31399: [SPARK-34259][SQL] Don't attempt to parse file-based partitions as special timestamps

2021-01-30 Thread GitBox
d80tb7 commented on pull request #31399: URL: https://github.com/apache/spark/pull/31399#issuecomment-770271817 > I would create a dedicated date/timestamp formatters that don't recognize special values instead of checking of every input string whether it is a special value or not. >