[GitHub] [spark] dcoliversun commented on a diff in pull request #35886: [SPARK-38582][K8S] Introduce buildEnvVars and buildEnvVarsWithFieldRef for KubernetesUtils to eliminate duplicate code pattern

dcoliversun commented on code in PR #35886: URL: https://github.com/apache/spark/pull/35886#discussion_r843449794 ## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala: ## @@ -381,4 +381,42 @@ object KubernetesUtils extends Logging

[GitHub] [spark] dcoliversun commented on a diff in pull request #35886: [SPARK-38582][K8S] Introduce buildEnvVars and buildEnvVarsWithFieldRef for KubernetesUtils to eliminate duplicate code pattern

dcoliversun commented on code in PR #35886: URL: https://github.com/apache/spark/pull/35886#discussion_r843449794 ## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala: ## @@ -381,4 +381,42 @@ object KubernetesUtils extends Logging

[GitHub] [spark] dcoliversun commented on a diff in pull request #35886: [SPARK-38582][K8S] Introduce buildEnvVars and buildEnvVarsWithFieldRef for KubernetesUtils to eliminate duplicate code pattern

dcoliversun commented on code in PR #35886: URL: https://github.com/apache/spark/pull/35886#discussion_r843447694 ## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala: ## @@ -74,16 +74,8 @@ private[spark] class Bas

[GitHub] [spark] dcoliversun commented on a diff in pull request #35886: [SPARK-38582][K8S] Introduce buildEnvVars and buildEnvVarsWithFieldRef for KubernetesUtils to eliminate duplicate code pattern

dcoliversun commented on code in PR #35886: URL: https://github.com/apache/spark/pull/35886#discussion_r843447694 ## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala: ## @@ -74,16 +74,8 @@ private[spark] class Bas