[GitHub] [spark] dengziming commented on a diff in pull request #38899: [SPARK-41349][CONNECT] Implement DataFrame.hint

2022-12-06 Thread GitBox
dengziming commented on code in PR #38899: URL: https://github.com/apache/spark/pull/38899#discussion_r1041709267 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/LiteralValueProtoConverter.scala: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache

[GitHub] [spark] dengziming commented on a diff in pull request #38899: [SPARK-41349][CONNECT] Implement DataFrame.hint

2022-12-06 Thread GitBox
dengziming commented on code in PR #38899: URL: https://github.com/apache/spark/pull/38899#discussion_r1040852710 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala: ## @@ -694,6 +685,18 @@ package object dsl { .build() } +

[GitHub] [spark] dengziming commented on a diff in pull request #38899: [SPARK-41349][CONNECT] Implement DataFrame.hint

2022-12-05 Thread GitBox
dengziming commented on code in PR #38899: URL: https://github.com/apache/spark/pull/38899#discussion_r1039377343 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/LiteralValueProtoConverterSuite.scala: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache