[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r678405214 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -112,19 +127,19 @@ object NumberConverte

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r678203059 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -89,6 +100,10 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r678202783 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,11 +49,22 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r678192485 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -112,19 +127,19 @@ object NumberConverte

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r678192485 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -112,19 +127,19 @@ object NumberConverte

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r678042820 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r677489071 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r677489071 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r677483113 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -89,6 +91,10 @@ object NumberConverter {

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r677357893 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r677354506 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r677354506 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676684793 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -89,6 +91,10 @@ object NumberConverter {

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676704901 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676686936 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676686936 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676691828 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676691828 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676688190 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676686936 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -49,12 +49,14 @@ object NumberConverter

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r676684793 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -89,6 +91,10 @@ object NumberConverter {

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r674466717 ## File path: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala ## @@ -218,6 +218,20 @@ class MathFunctionsSuite extends Query

[GitHub] [spark] dgd-contributor commented on a change in pull request #33459: [SPARK-36229][SQL] conv() inconsistently handles invalid strings with more than 64 invalid characters and return wrong va

dgd-contributor commented on a change in pull request #33459: URL: https://github.com/apache/spark/pull/33459#discussion_r674466634 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala ## @@ -89,6 +91,10 @@ object NumberConverter {