[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672809311 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala ## @@ -51,7 +51,7 @@ object CustomMetrics {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672809311 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala ## @@ -51,7 +51,7 @@ object CustomMetrics {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672811174 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriterMetricSuite.scala ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672810180 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala ## @@ -51,7 +51,7 @@ object CustomMetrics {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672809311 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/CustomMetrics.scala ## @@ -51,7 +51,7 @@ object CustomMetrics {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672016647 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala ## @@ -852,6 +857,33 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33239: [SPARK-36030][SQL] Support DS v2 metrics at writing path

2021-07-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #33239: URL: https://github.com/apache/spark/pull/33239#discussion_r672016597 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala ## @@ -852,6 +857,33 @@ class