[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36832: [SPARK-39439][SHS] Check final file if in-progress event log file does not exist

2022-06-13 Thread GitBox
dongjoon-hyun commented on code in PR #36832: URL: https://github.com/apache/spark/pull/36832#discussion_r895397461 ## core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala: ## @@ -715,7 +715,7 @@ private[history] class FsHistoryProvider(conf: SparkConf, c

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36832: [SPARK-39439][SHS] Check final file if in-progress event log file does not exist

2022-06-13 Thread GitBox
dongjoon-hyun commented on code in PR #36832: URL: https://github.com/apache/spark/pull/36832#discussion_r895389373 ## core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala: ## @@ -221,6 +222,48 @@ abstract class FsHistoryProviderSuite extends SparkFu

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36832: [SPARK-39439][SHS] Check final file if in-progress event log file does not exist

2022-06-13 Thread GitBox
dongjoon-hyun commented on code in PR #36832: URL: https://github.com/apache/spark/pull/36832#discussion_r895388483 ## core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala: ## @@ -221,6 +222,48 @@ abstract class FsHistoryProviderSuite extends SparkFu

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36832: [SPARK-39439][SHS] Check final file if in-progress event log file does not exist

2022-06-12 Thread GitBox
dongjoon-hyun commented on code in PR #36832: URL: https://github.com/apache/spark/pull/36832#discussion_r895262820 ## core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala: ## @@ -747,6 +747,15 @@ private[history] class FsHistoryProvider(conf: SparkConf,

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36832: [SPARK-39439][SHS] Check final file if in-progress event log file does not exist

2022-06-12 Thread GitBox
dongjoon-hyun commented on code in PR #36832: URL: https://github.com/apache/spark/pull/36832#discussion_r895262820 ## core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala: ## @@ -747,6 +747,15 @@ private[history] class FsHistoryProvider(conf: SparkConf,

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36832: [SPARK-39439][SHS] Check final file if in-progress event log file does not exist

2022-06-12 Thread GitBox
dongjoon-hyun commented on code in PR #36832: URL: https://github.com/apache/spark/pull/36832#discussion_r895261688 ## core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala: ## @@ -747,6 +747,15 @@ private[history] class FsHistoryProvider(conf: SparkConf,