[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39541: [SPARK-42043][CONNECT] Scala Client Result with E2E Tests

2023-01-19 Thread GitBox
dongjoon-hyun commented on code in PR #39541: URL: https://github.com/apache/spark/pull/39541#discussion_r1082019043 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apa

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39541: [SPARK-42043][CONNECT] Scala Client Result with E2E Tests

2023-01-19 Thread GitBox
dongjoon-hyun commented on code in PR #39541: URL: https://github.com/apache/spark/pull/39541#discussion_r1082019043 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apa

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39541: [SPARK-42043][CONNECT] Scala Client Result with E2E Tests

2023-01-19 Thread GitBox
dongjoon-hyun commented on code in PR #39541: URL: https://github.com/apache/spark/pull/39541#discussion_r1081977091 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/util/Cleaner.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39541: [SPARK-42043][CONNECT] Scala Client Result with E2E Tests

2023-01-19 Thread GitBox
dongjoon-hyun commented on code in PR #39541: URL: https://github.com/apache/spark/pull/39541#discussion_r1081964708 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/util/Cleaner.scala: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39541: [SPARK-42043][CONNECT] Scala Client Result with E2E Tests

2023-01-19 Thread GitBox
dongjoon-hyun commented on code in PR #39541: URL: https://github.com/apache/spark/pull/39541#discussion_r1081947954 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apa

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39541: [SPARK-42043][CONNECT] Scala Client Result with E2E Tests

2023-01-19 Thread GitBox
dongjoon-hyun commented on code in PR #39541: URL: https://github.com/apache/spark/pull/39541#discussion_r1081945632 ## connector/connect/client/jvm/pom.xml: ## @@ -47,6 +47,12 @@ + Review Comment: Hi, @hvanhovell . I believe this is not a