[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-08 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1222677031 ## core/src/main/resources/error/error-classes.json: ## @@ -1539,6 +1539,13 @@ "Parse Mode: . To process malformed records as null result, try setting the

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-08 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1222675432 ## sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoTableSuiteBase.scala: ## @@ -0,0 +1,1344 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-07 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1222454470 ## core/src/main/resources/error/error-classes.json: ## @@ -1513,6 +1513,13 @@ "Parse Mode: . To process malformed records as null result, try setting the

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-07 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1222454470 ## core/src/main/resources/error/error-classes.json: ## @@ -1513,6 +1513,13 @@ "Parse Mode: . To process malformed records as null result, try setting the

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-07 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1222445046 ## core/src/main/resources/error/error-classes.json: ## @@ -1513,6 +1513,13 @@ "Parse Mode: . To process malformed records as null result, try setting the

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220881660 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeRowsExec.scala: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220878555 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeRowsExec.scala: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220856502 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/MergeRows.scala: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220852840 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala: ## @@ -187,6 +187,16 @@ case object PREFER_SHUFFLE_HASH extends JoinStrate

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220851730 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4280,6 +4280,20 @@ object SQLConf { .checkValue(_ >= 0, "The threshold o

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220851008 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4280,6 +4280,20 @@ object SQLConf { .checkValue(_ >= 0, "The threshold o

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220843453 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4280,6 +4280,20 @@ object SQLConf { .checkValue(_ >= 0, "The threshold o

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41448: [SPARK-43885][SQL] DataSource V2: Handle MERGE commands for delta-based sources

2023-06-06 Thread via GitHub
dongjoon-hyun commented on code in PR #41448: URL: https://github.com/apache/spark/pull/41448#discussion_r1220838583 ## core/src/main/resources/error/error-classes.json: ## @@ -1513,6 +1513,13 @@ "Parse Mode: . To process malformed records as null result, try setting the