[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-29 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-516111330 Hi, @maropu . Could you give us some advice on the following? - https://github.com/apache/spark/pull/24881#discussion_r308373086

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-24 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-514823702 BTW, thank you for your patience! This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-24 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-514690483 SQL Function and SQL Language syntax is different, @DylanGuedes . 1. The one you mention

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-23 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-514454623 `FILTER` is not supported syntax, isn't it? The unsupported syntax is a good reason to create a JIRA issue. In this PR, you can file

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512382094 Yes. Please search the JIRA and file all of them if they don't exist. For `explain (costs off)`, there might exist one.

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512360035 It's not missed. It's a temporary view. We don't need to drop it manually.

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-17 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-512346931 Hi, @DylanGuedes . I made a PR to you, https://github.com/DylanGuedes/spark/pull/1 . - It replaces REL_12_BETA1 with REL_12_BETA2.

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-16 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-511959776 Never mind~ Please take your time. This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-16 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-511879098 Gentle ping. This is an automated message from the Apache Git Service.

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-06 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-508946078 Thank you for update. We need to embed the JIRA ID of new issues in the file in this PR.

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-07-05 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-508672902 Hi, @DylanGuedes . The output file (21,485 line) looks ridiculously bigger than the original one (3823 line). -

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-06-19 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-503744475 The failure is due to the wrong generated output. Please configure your Python environment and regenerate this.

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-06-19 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-503743521 Retest this please. This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql

2019-06-15 Thread GitBox
dongjoon-hyun commented on issue #24881: [SPARK-23160][SQL][TEST] Port window.sql URL: https://github.com/apache/spark/pull/24881#issuecomment-502417006 ok to test This is an automated message from the Apache Git Service. To