[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-510081293 Merged to master. Thank you, @srowen .

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509832006 Retest this please. This is an

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509729034 Thank you so much for review and approval, @srowen ! Yes. I'll wait for @vanzin 's comment for one

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509695599 Hi, @srowen . Could you review this once more please?

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509367503 The default value is increased to `Int.MaxValue`, too.

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509365358 For the default value, I agree with your concerns. Although this default value, 1M, is big

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509350569 Could you review once more? I addressed some of the comments. For the followings, please let me know

[GitHub] [spark] dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration

dongjoon-hyun commented on issue #25072: [SPARK-28294][CORE] Support `spark.history.fs.cleaner.maxNum` configuration URL: https://github.com/apache/spark/pull/25072#issuecomment-509336257 Thank you for review, @srowen ! I'll update soon.