[GitHub] [spark] dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-14 Thread GitBox
dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-541956052 I missed the location, @DylanGuedes . Sorry, but could you make a PR after putting the file into the correct location `sql/c

[GitHub] [spark] dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-14 Thread GitBox
dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-541953750 Oops. Yes. We moved the location and this PR is very old. For now, #26116 is failing. I'll revert this PR. Sorry guys. -

[GitHub] [spark] dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-541376447 I checked the diff. There is additional addition from line 1257, but that is irrelevant to this PR because this PR is only for

[GitHub] [spark] dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-541374355 Retest this please. This is an automated message from the Apac

[GitHub] [spark] dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-02 Thread GitBox
dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-537774869 Hmm. Still `Result did not match for query ` for the following. ``` SELECT four, ten/4 as two, sum(ten/4) over (partit