[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-584430824 BTW, @yhuai . As I mentioned before to @liancheng , the transition from `orc-nohive` to `hive-storage-api` is not made by me. That

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-584428614 Thank you, @yhuai . During weekend, I missed your comment here. Th

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-575763775 Historically I was against the change because `sql/core` is designed to use ORC without `-Phive`. And, Apache ORC `nohive` classifi

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-575762407 Yes. It's correct. The removal of `nohive` classifier in `Hive 2.3` is @wangyum 's change. While updating for Hadoop 3.2,

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-558919112 One additional stuff is `sql/core` module. Previously, `hadoop-3.2` replaces the previous ORC code with `Hive code`. When `-P

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-558918603 `-Phive` enables modules like `hive` and `hive-thriftserver`. `-Phive-1.2` and `-Phive-2.3` chooses the Hive version (and it's cl

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-557819560 Thank you all. I'll merge this to the master and continue to work. This keeps every existing features. I'm sure it's safe until now

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-557593107 Thank you, @HyukjinKwon ! This is an automated message from the Ap

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-557174280 Hi, @shaneknapp . We are changing the build combination which will affects the Jenkins jobs. ---

[GitHub] [spark] dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

dongjoon-hyun commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles URL: https://github.com/apache/spark/pull/26619#issuecomment-557173375 Hi, All. I updated the PR description. This PR successfully verified the existing profiles and this PR also updates PR build