[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-689673091 Got it. If the PR is ready, I'll ping both of you. :) This is an automated message from the Apache Git Ser

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-689425629 BTW, @cloud-fan . Is @HeartSaVioR working on that? I'm wondering the reason why you ping him in that task. ---

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-689372116 Sure, I'll make a PR for that tomorrow, @cloud-fan . This is an automated message from the Apache Git Serv

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662504233 Merged to master/3.0 since GitHub Action passed. Thank you all. I'll make a backporting PR to branch-2.4.

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662396395 Thank you, @HyukjinKwon . This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662394998 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662341945 Thank you, @cloud-fan . The PR is updated to use `Seq` instead of `Map`. This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662331774 I updated the PR according to your comment, @cloud-fan . It looks much better indeed. Thank you so much.

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662307263 Hi, @cloud-fan and @HyukjinKwon . This PR aims to fix this problem completely. Please review the approach. -