[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689995915 Ya. It looks okay for now. `branch-2.4` Maven also passed like the following. The `branch-3.0` and `master` Jenkins jobs didn't trigger on this commit yet and those will

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689984279 I'll monitor Jenkins status. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689981755 I verified again locally. It works. Given the error message from Jenkins, the map seems to be overwritten to the read options back again by the streaming query. If

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689979351 BTW, `GitHub Action` also passed, so I merged this. This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689978839 Ur, let me check again. I checked in IntelliJ and run `build/sbt` streaming tests locally. This is an

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689941497 Thank you, @viirya . Merged to master/3.0/2.4. This is an automated message from the Apache Git Service.

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689927111 Thank you, @HeartSaVioR . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689910378 Thank you, @cloud-fan ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

2020-09-09 Thread GitBox
dongjoon-hyun commented on pull request #29701: URL: https://github.com/apache/spark/pull/29701#issuecomment-689905168 cc @cloud-fan and @HeartSaVioR This is an automated message from the Apache Git Service. To respond to