[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-30 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-736067925 Thank you so much, @holdenk and @viirya . Merged to master for Apache Spark 3.1.0. This is an

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-30 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-735912350 Hi, @holdenk and @viirya and @dbtsai . Could you review this, please? This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-29 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-735552719 Got it, @zsxwing . This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-29 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-735473004 Hi, @zsxwing and @viirya . I addressed your comments. Could you review once more please if you have a chance?

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-26 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-734527796 Thank you so much for your review, @viirya ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733906102 BTW, cc @dbtsai , too. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733905003 Thank you, @holdenk . Sorry for pinging you on the holiday season. This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733866284 Could you review this PR once more please, @viirya ? This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-25 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733837333 Thank you for review, @Tagar . Yes, they are separate options: - `spark.storage.decommission.shuffleBlocks.enabled` - `spark.storage.decommission.rddBlocks.enabled`

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-24 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733492363 It's a little weird because it passed locally. ``` $ build/sbt "core/testOnly *.FallbackStorageSuite" ... [info] FallbackStorageSuite: [info] - fallback

[GitHub] [spark] dongjoon-hyun commented on pull request #30492: [SPARK-33545][CORE] Support Fallback Storage during Worker decommission

2020-11-24 Thread GitBox
dongjoon-hyun commented on pull request #30492: URL: https://github.com/apache/spark/pull/30492#issuecomment-733260121 Could you review this, @holdenk , @viirya , @mridulm ? This is an automated message from the Apache Git