[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-09 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1151330081 Thank you everyone. This is closed according to @cloud-fan 's approach. - https://github.com/apache/spark/pull/34929#discussion_r893624590 -- This is an automated message from t

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-09 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150840143 As an alternative, reverting PR is also under testing. - https://github.com/apache/spark/pull/36819 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-09 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150792308 Here - https://github.com/apache/spark/pull/34929#discussion_r893175026 - https://github.com/apache/spark/pull/34929#discussion_r893184019 -- This is an automated message fro

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-09 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150777964 Let me comment on the original PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-09 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150777585 That golden files in `branch-3.2` are the one already generated by that method, @cloud-fan . And, it fails in GitHub Action environment. -- This is an automated message from the A

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-09 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150752323 Here is the summary. - The original PR proposed `Make CTE IDs more deterministic by starting from 0 for each query`. - However, the current status generate indeterministic

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-08 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150727977 `q5` failure is fixed but `q4` seems to be indeterministic for some reasons in `branch-3.2`. The result seems to be oscillated with new values and old values. Let me take a look at

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-08 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150604227 Thank you, @sunchao and @cloud-fan . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-08 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150603278 Thank you, @HyukjinKwon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] dongjoon-hyun commented on pull request #36815: [SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files

2022-06-08 Thread GitBox
dongjoon-hyun commented on PR #36815: URL: https://github.com/apache/spark/pull/36815#issuecomment-1150602874 cc @maryannxue , @cloud-fan , @HyukjinKwon , @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U