[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-17 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1196822211 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-04 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1185326718 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-03 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1183995046 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumns.scala: ## @@ -589,8 +631,10 @@ case class ResolveDefaultColumns( resol

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-02 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1183114221 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -218,10 +219,29 @@ object ResolveDefaultColumns { } else

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-02 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1182773208 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-01 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1181991609 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -343,4 +363,11 @@ object ResolveDefaultColumns { v1Cata

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-01 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1181933218 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -343,4 +363,11 @@ object ResolveDefaultColumns { v1Cata

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-05-01 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1181927923 ## sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala: ## @@ -1044,7 +1044,7 @@ class InsertSuite extends DataSourceTest with SharedSparkSession {

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-04-28 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1180841407 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -344,3 +358,13 @@ object ResolveDefaultColumns { } }

[GitHub] [spark] dtenedor commented on a diff in pull request #40996: [SPARK-43313][SQL] Adding missing column DEFAULT values for MERGE INSERT actions

2023-04-28 Thread via GitHub
dtenedor commented on code in PR #40996: URL: https://github.com/apache/spark/pull/40996#discussion_r1180841211 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -344,3 +358,13 @@ object ResolveDefaultColumns { } }