[GitHub] [spark] dtenedor commented on pull request #39747: [SPARK-42191][SQL] Support udf 'luhn_check'

2023-01-30 Thread via GitHub
dtenedor commented on PR #39747: URL: https://github.com/apache/spark/pull/39747#issuecomment-1409030293 @srowen yeah, we should apply discretion for those functions on that list. There's something to be said for having a built-in library of functions that are useful enough for general-pur

[GitHub] [spark] dtenedor commented on pull request #39747: [SPARK-42191][SQL] Support udf 'luhn_check'

2023-01-30 Thread via GitHub
dtenedor commented on PR #39747: URL: https://github.com/apache/spark/pull/39747#issuecomment-1409008814 Hi @srowen I get where you're coming from. For background, we have a Jira [1] to add a suite of data masking functions into Spark. This is one of a family of such proposed functions. The

[GitHub] [spark] dtenedor commented on pull request #39747: [SPARK-42191][SQL] Support udf 'luhn_check'

2023-01-25 Thread via GitHub
dtenedor commented on PR #39747: URL: https://github.com/apache/spark/pull/39747#issuecomment-1404167805 The general algorithm and test coverage look correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov