[GitHub] [spark] eejbyfeldt commented on pull request #27153: [SPARK-20384][SQL] Support value class in schema of Dataset (without breaking existing current projection)

eejbyfeldt commented on pull request #27153: URL: https://github.com/apache/spark/pull/27153#issuecomment-872867876 I looked some more at this and realised what the problem with `Tuples` is, it guess it all related to when a value class it its underlying type and when it is not

[GitHub] [spark] eejbyfeldt commented on pull request #27153: [SPARK-20384][SQL] Support value class in schema of Dataset (without breaking existing current projection)

eejbyfeldt commented on pull request #27153: URL: https://github.com/apache/spark/pull/27153#issuecomment-866238761 @mickjermsurawong-stripe Have you had anytime to look at updating the branch? I you don't have time to prepare full patch, I could help out with unittests and such if you

[GitHub] [spark] eejbyfeldt commented on pull request #27153: [SPARK-20384][SQL] Support value class in schema of Dataset (without breaking existing current projection)

eejbyfeldt commented on pull request #27153: URL: https://github.com/apache/spark/pull/27153#issuecomment-859592841 Hi @mickjermsurawong-stripe ! Great to hear, looking forward to updated changes. Also my PR https://github.com/apache/spark/pull/32783 got merged, so rebasing this branch on

[GitHub] [spark] eejbyfeldt commented on pull request #27153: [SPARK-20384][SQL] Support value class in schema of Dataset (without breaking existing current projection)

eejbyfeldt commented on pull request #27153: URL: https://github.com/apache/spark/pull/27153#issuecomment-856536881 I am interested in support for value classes that is added/fixed in this branch. To me the changes looks like they are a still valid approach of adding the support.