eugen-prokhorenko opened a new pull request #25187: [SPARK-28434][MLlib] 
Decision Tree model isn't equal after save and load
URL: https://github.com/apache/spark/pull/25187
 
 
   ## What changes were proposed in this pull request?
   
   Check other `DecisionTreeModel`'s node's `stats` fields by using 
`InformationGainStats`'s overridden `equals` method.
   
   The issue is that if we compare more fields of the `InformationGainStats` 
object, we'll see that they are different, unlike the only checked before 
`gain` field.
   
   ## How was this patch tested?
   
   `build/mvn -e -Dtest=none 
-DwildcardSuites=org.apache.spark.mllib.tree.DecisionTreeSuite test` against 
`master` branch
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to