[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-07 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654992303 Done, and thank you all for a great experience! This is an automated message from the Apache Git Service. To r

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-06 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654559706 looks like a flaky test failed unfortunately This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-06 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654437327 Not sure why but it looks like someone aborted the build mid-way. Can someone please kick-off a new build? I don't think I'm not on the jenkins white-list ---

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-05 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-653940530 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-05 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-653934332 test this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-01 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-652633017 No problems, it was worth a try. Thanks for looking into it! This is an automated message from the Apache Git

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-01 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-652443144 Hey @cloud-fan , I've been attempting to make this idea work for a couple of weeks now without success. I made some small changes and am able to get the Scala code to c

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-18 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-646429505 > Can you explain more about this? Please see the comment from @dbtsai [here](https://github.com/apache/spark/pull/27066#issuecomment-609512144) for a more thorough ex

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-16 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-645047815 @cloud-fan I've made fairly significant changes to the implementation in order to address the issue where poorly optimized physical plans resulted in massive amounts of java c

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-11 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-642984217 > BTW Spark does common subexpressions elimination during codegen, so repeated expressions don't mean they are evaluated repeatedly. You're right, I forgot about this.

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-09 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-640747267 @cloud-fan Thanks for your PR. I've merged your changes into this branch with some modifications in order to pass the tests. > Remove the SQL API. It's unclear