gatorsmile commented on a change in pull request #24922: [SPARK-28120][SS]
Rocksdb state storage implementation
URL: https://github.com/apache/spark/pull/24922#discussion_r333772305
##########
File path: sql/core/pom.xml
##########
@@ -147,6 +147,12 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+ <!-- RocksDB dependency for Structured Streaming State Store -->
+ <dependency>
+ <groupId>org.rocksdb</groupId>
+ <artifactId>rocksdbjni</artifactId>
Review comment:
RocksDB might not be the best backend. Instead of adding the extra
dependency, I think we should just do it as a separate third-party package. The
community can always build their own backend based on their needs. Doing it is
simple.
Can you submit it to https://spark-packages.org/?
cc @marmbrus @tdas @zsxwing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
