[GitHub] [spark] gengliangwang commented on a change in pull request #34681: [SPARK-37438][SQL] ANSI mode: Use store assignment rules for resolving function invocation

2021-11-22 Thread GitBox
gengliangwang commented on a change in pull request #34681: URL: https://github.com/apache/spark/pull/34681#discussion_r754415776 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -348,6 +290,9 @@ object

[GitHub] [spark] gengliangwang commented on a change in pull request #34681: [SPARK-37438][SQL] ANSI mode: Use store assignment rules for resolving function invocation

2021-11-22 Thread GitBox
gengliangwang commented on a change in pull request #34681: URL: https://github.com/apache/spark/pull/34681#discussion_r754304433 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala ## @@ -31,75 +31,49 @@ import

[GitHub] [spark] gengliangwang commented on a change in pull request #34681: [SPARK-37438][SQL] ANSI mode: Use store assignment rules for resolving function invocation

2021-11-22 Thread GitBox
gengliangwang commented on a change in pull request #34681: URL: https://github.com/apache/spark/pull/34681#discussion_r754303746 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out ## @@ -545,37 +539,33 @@ AABB -- !query SELECT