[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890447000 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,81 @@ abstract class SparkFunSuite } } + /** + * Checks an exception

[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890443211 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,81 @@ abstract class SparkFunSuite } } + /** + * Checks an exception

[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890433533 ## core/src/main/java/org/apache/spark/SparkThrowable.java: ## @@ -35,6 +35,9 @@ public interface SparkThrowable { // Succinct, human-readable, unique, and

[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890432585 ## core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java: ## @@ -28,6 +28,7 @@ @Private public final class SparkOutOfMemoryError extends

[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890392259 ## core/src/main/scala/org/apache/spark/SparkException.scala: ## @@ -28,23 +28,47 @@ class SparkException( message: String, cause: Throwable,

[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890391580 ## core/src/main/scala/org/apache/spark/SparkException.scala: ## @@ -28,23 +28,47 @@ class SparkException( message: String, cause: Throwable,

[GitHub] [spark] gengliangwang commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

gengliangwang commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r890373656 ## core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java: ## @@ -28,6 +28,7 @@ @Private public final class SparkOutOfMemoryError extends