[GitHub] [spark] gengliangwang commented on a diff in pull request #40710: [SPARK-43071][SQL] Support SELECT DEFAULT with ORDER BY, LIMIT, OFFSET for INSERT source relation

2023-04-07 Thread via GitHub
gengliangwang commented on code in PR #40710: URL: https://github.com/apache/spark/pull/40710#discussion_r1161010584 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumns.scala: ## @@ -91,6 +90,25 @@ case class ResolveDefaultColumns(catalog:

[GitHub] [spark] gengliangwang commented on a diff in pull request #40710: [SPARK-43071][SQL] Support SELECT DEFAULT with ORDER BY, LIMIT, OFFSET for INSERT source relation

2023-04-07 Thread via GitHub
gengliangwang commented on code in PR #40710: URL: https://github.com/apache/spark/pull/40710#discussion_r1161009871 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumns.scala: ## @@ -91,6 +90,25 @@ case class ResolveDefaultColumns(catalog: