[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-11-03 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-549176590 > I'm asking the reverse question - is there anything that works before this change but not after? I understand it makes

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-11-02 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-549109732 > yea, that's ok to change it. Because of the behaviour change as @srowen said, we might need to update the migration gui

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-11-02 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-549109522 > I agree that compatibility is a minor issue here. But it also sounds like this change allows things to work that did no

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-11-01 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-549015878 @maropu @srowen Just double confirm, are you ok with the proposal? -

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-10-31 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-548515947 retest this please. This is an automated message from th

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-10-30 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-548025251 @amanomer Could you add some test cases? This is an auto

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-10-30 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-548025012 ok to test This is an automated message from the Apache

[GitHub] [spark] gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array

2019-10-30 Thread GitBox
gengliangwang commented on issue #26324: [SPARK-29462] The data type of "array()" should be array URL: https://github.com/apache/spark/pull/26324#issuecomment-547999191 I think the proposal is reasonable. After https://github.com/apache/spark/pull/26107, we can't store string type into