[GitHub] [spark] gengliangwang commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-23 Thread GitBox
gengliangwang commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-784794922 GA passes. Merging to master. @maropu @cloud-fan thank you so much for the review! This is an automated

[GitHub] [spark] gengliangwang commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-22 Thread GitBox
gengliangwang commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-783271372 @maropu @cloud-fan all test passes and comments addressed. Could you take another look? This is an auto

[GitHub] [spark] gengliangwang commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-18 Thread GitBox
gengliangwang commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-781519754 @maropu Thanks for the comments! I was on vacation. I will update this PR soon. This is an automated mess

[GitHub] [spark] gengliangwang commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-09 Thread GitBox
gengliangwang commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-776407799 > Any plan to update the ANSI document along with this change? I plan to do it in a follow-up PR, to make the review easier. There is an umbrella jira for it: htt

[GitHub] [spark] gengliangwang commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-09 Thread GitBox
gengliangwang commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-776066948 > All the numeric types are also atomic types, so this match cannot happen? Am I missing something? @maropu there is an object `NumericType` and it can't be matched

[GitHub] [spark] gengliangwang commented on pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-03 Thread GitBox
gengliangwang commented on pull request #31349: URL: https://github.com/apache/spark/pull/31349#issuecomment-772627323 retest this please. This is an automated message from the Apache Git Service. To respond to the message, p