[GitHub] [spark] gengliangwang commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-13 Thread GitBox
gengliangwang commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-840597293 Merging to master. @maropu Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] gengliangwang commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
gengliangwang commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-840281783 > Just out of curiosity; Any reason to pick up try_add+try_divide instead of try_add+try_multiple? IMO, divide by 0 error is more common in ETL/ML jobs than integral

[GitHub] [spark] gengliangwang commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
gengliangwang commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839801210 @cloud-fan @maropu Sorry for the delay. This one is ready for review now. -- This is an automated message from the Apache Git Service. To respond to the message, please l