[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null

2021-08-16 Thread GitBox
gengliangwang commented on pull request #33751: URL: https://github.com/apache/spark/pull/33751#issuecomment-899621243 Got it. I am closing this PR and related JIRAs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null

2021-08-16 Thread GitBox
gengliangwang commented on pull request #33751: URL: https://github.com/apache/spark/pull/33751#issuecomment-899595580 > As far as I know we implemented ANSI intervals in some kind of strict mode (ANSI mode) everywhere, and ignored the ANSI mode SQL config. @MaxGekk I was testing th

[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null

2021-08-16 Thread GitBox
gengliangwang commented on pull request #33751: URL: https://github.com/apache/spark/pull/33751#issuecomment-899566916 @cloud-fan I have created https://issues.apache.org/jira/browse/SPARK-36523 for the day-time interval. The method `castStringToYMInterval` is used in multiple places. I

[GitHub] [spark] gengliangwang commented on pull request #33751: [SPARK-36522][SQL] Casting invalid string to year-month interval should return null

2021-08-16 Thread GitBox
gengliangwang commented on pull request #33751: URL: https://github.com/apache/spark/pull/33751#issuecomment-899545402 jenkins, retest this please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t