[GitHub] [spark] gengliangwang commented on pull request #36475: [SPARK-38869][SQL] Respect table capability ACCEPT_ANY_SCHEMA in DEFAULT column resolution

2022-05-23 Thread GitBox
gengliangwang commented on PR #36475: URL: https://github.com/apache/spark/pull/36475#issuecomment-1134763429 I am merging this one to unblock @dtenedor. He made 70 commits for this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [spark] gengliangwang commented on pull request #36475: [SPARK-38869][SQL] Respect table capability ACCEPT_ANY_SCHEMA in DEFAULT column resolution

2022-05-21 Thread GitBox
gengliangwang commented on PR #36475: URL: https://github.com/apache/spark/pull/36475#issuecomment-1133677331 LGTM except minor comment in the test case. I think we can just have one simple test case for insertion. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] gengliangwang commented on pull request #36475: [SPARK-38869][SQL] Respect table capability ACCEPT_ANY_SCHEMA in DEFAULT column resolution

2022-05-19 Thread GitBox
gengliangwang commented on PR #36475: URL: https://github.com/apache/spark/pull/36475#issuecomment-1131731396 @dtenedor after a closer look, I think we can resolve this in a simpler way. I make a PR on your repo: https://github.com/dtenedor/spark/pull/4 You can merge it on your repo if