[GitHub] [spark] grundprinzip commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL

2022-11-03 Thread GitBox
grundprinzip commented on PR #38475: URL: https://github.com/apache/spark/pull/38475#issuecomment-1302731774 Yes, my probably my question is if (1) will work and we don't have to do heavy lifting? Once you did (1) and have the schema you could wrap the input plan with the select. --

[GitHub] [spark] grundprinzip commented on pull request #38475: [SPARK-40992][CONNECT] Support toDF(columnNames) in Connect DSL

2022-11-03 Thread GitBox
grundprinzip commented on PR #38475: URL: https://github.com/apache/spark/pull/38475#issuecomment-1302724487 @amaliujia quick question, looking at the code in Dataset, why do we actually need to implement this on the server? The renaming could in theory be rewritten into a select with