grundprinzip commented on PR #39294:
URL: https://github.com/apache/spark/pull/39294#issuecomment-1478626808
The current level of proto compat required is the most strict one which
requires to be fully compatible, even with the naming of the fields. Strictly
speaking, this is not required t
grundprinzip commented on PR #39294:
URL: https://github.com/apache/spark/pull/39294#issuecomment-1478606975
![SCR-20230321-v7f](https://user-images.githubusercontent.com/3421/226745165-60b1611a-2ec5-4ddf-98c0-61c3a180ed9c.png)
Verifying that the broken build is reported.
--
This i
grundprinzip commented on PR #39294:
URL: https://github.com/apache/spark/pull/39294#issuecomment-1368423420
There is another thing. We need the pre merge check to make sure we
understand what's going on and potentially something like Mima excludes when
comparing against the released branch
grundprinzip commented on PR #39294:
URL: https://github.com/apache/spark/pull/39294#issuecomment-1368422894
> > If everything else is green and only the Buf check is read someone with
the power to merge can decide to simply merge the change.
>
>
>
> If breaking change is all