[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1286014657 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -53,11 +60,33 @@ private[client] object GrpcExce

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1286014657 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -53,11 +60,33 @@ private[client] object GrpcExce

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1286014657 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -53,11 +60,33 @@ private[client] object GrpcExce

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1285579913 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ErrorFactoryBuilder.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1285573500 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ErrorFactoryBuilder.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1285573500 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ErrorFactoryBuilder.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-07 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1285569259 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -47,11 +52,37 @@ private[client] object GrpcExce

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-03 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1282903796 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -47,11 +52,37 @@ private[client] object GrpcExce

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-02 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1282395373 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -47,11 +52,37 @@ private[client] object GrpcExce

[GitHub] [spark] heyihong commented on a diff in pull request #42266: [SPARK-44575][SQL][CONNECT] Implement basic error translation

2023-08-02 Thread via GitHub
heyihong commented on code in PR #42266: URL: https://github.com/apache/spark/pull/42266#discussion_r1282395373 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ## @@ -47,11 +52,37 @@ private[client] object GrpcExce