[GitHub] [spark] holdenk commented on pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-23 Thread GitBox
holdenk commented on pull request #29788: URL: https://github.com/apache/spark/pull/29788#issuecomment-698021508 I think it would be good to see your proposal in code @Ngone51 because I'm not 100% sure what you mean. I would really like to see both this and the precursor tested more

[GitHub] [spark] holdenk commented on pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-19 Thread GitBox
holdenk commented on pull request #29788: URL: https://github.com/apache/spark/pull/29788#issuecomment-695556053 (willing to switch back to -0 once the original issue is addressed, I just don't want us in a state with broken tests as normal).

[GitHub] [spark] holdenk commented on pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-19 Thread GitBox
holdenk commented on pull request #29788: URL: https://github.com/apache/spark/pull/29788#issuecomment-695530700 Since there was another PR in the same area committed that broke the existing integration tests in this area I don't feel confident with my soft reservations and switching to a

[GitHub] [spark] holdenk commented on pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-17 Thread GitBox
holdenk commented on pull request #29788: URL: https://github.com/apache/spark/pull/29788#issuecomment-694327672 Please tag this PR as WIP until it is tested, thanks for working on improving the code though @Ngone51 :)