huaxingao commented on code in PR #36777:
URL: https://github.com/apache/spark/pull/36777#discussion_r890673570
##########
core/src/main/scala/org/apache/spark/SecurityManager.scala:
##########
@@ -87,10 +87,14 @@ private[spark] class SecurityManager(
private var secretKey: String = _
logInfo("SecurityManager: authentication " + (if (authOn) "enabled" else
"disabled") +
"; ui acls " + (if (aclsOn) "enabled" else "disabled") +
- "; users with view permissions: " + viewAcls.toString() +
- "; groups with view permissions: " + viewAclsGroups.toString() +
- "; users with modify permissions: " + modifyAcls.toString() +
- "; groups with modify permissions: " + modifyAclsGroups.toString())
+ "; users with view permissions: " +
Review Comment:
nit: there is an extra space after `users`
##########
core/src/main/scala/org/apache/spark/SecurityManager.scala:
##########
@@ -87,10 +87,14 @@ private[spark] class SecurityManager(
private var secretKey: String = _
logInfo("SecurityManager: authentication " + (if (authOn) "enabled" else
"disabled") +
"; ui acls " + (if (aclsOn) "enabled" else "disabled") +
- "; users with view permissions: " + viewAcls.toString() +
- "; groups with view permissions: " + viewAclsGroups.toString() +
- "; users with modify permissions: " + modifyAcls.toString() +
- "; groups with modify permissions: " + modifyAclsGroups.toString())
+ "; users with view permissions: " +
+ (if (viewAcls.nonEmpty) viewAcls.mkString(",") else "EMPTY") +
Review Comment:
nit: In `mkString(",")`, add an empty space after `,` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
