[GitHub] [spark] huaxingao commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

huaxingao commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-648399677 I will close this PR. Thank you all for reviewing. This is an automated message from the Apache Git Service.

[GitHub] [spark] huaxingao commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

huaxingao commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-632379756 I think this is an okay abstraction because ```k``` corresponds to number of clusters. Selecting the number of clusters is similar for the five different clustering algorithms

[GitHub] [spark] huaxingao commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

huaxingao commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-632252188 cc @srowen This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] huaxingao commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

huaxingao commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-632251801 Actually the param in ALS is called ```rank``` instead of ```k```. I am a little hesitant to reuse ```k``` in RankingEvaluator because it has a totally different meaning. I