[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-30 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-569708529 Added these changes under `spark.sql.legacy.xxx`. Also made it true by default to follow the hive functionality. Mi

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-30 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-569017566 @cloud-fan @maropu @HyukjinKwon please review the changes. ---

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-22 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-567886469 @maropu @cloud-fan @HyukjinKwon Anything other changes needs to be done for this one?

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-566835810 Can you please review the test suite cc @maropu @cloud-fan @HyukjinKwon ---

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-17 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-566835810 Can you please review the test suite. cc @maropu @cloud-fan @HyukjinKwon --

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-16 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-566144848 Test Suite added. cc @maropu @cloud-fan @HyukjinKwon @dongjoon-hyun --

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-14 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-565684156 cc @HyukjinKwon @dongjoon-hyun @maropu @cloud-fan

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-13 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-565276172 > Can you show how you manually tested in PR description in both Spark and Hive? I have attached the screenshot

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-12 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-564965509 As of now i have checked for hive only. It supported there using `ADD FILE` command only. I think allowing to add direc

[GitHub] [spark] iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI

2019-12-12 Thread GitBox
iRakson edited a comment on issue #26863: [SPARK-30234]ADD FILE cannot add directories from sql CLI URL: https://github.com/apache/spark/pull/26863#issuecomment-564965509 As of now i have checked for hive only. It supported there using ADD FILE command only. I think allowing to add directo