[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-12-02 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r534502351 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala ## @@ -19,26 +19,27 @@ package

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-12-01 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r533823907 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -2555,11 +2557,15 @@ class DataSourceV2SQLSuite

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-27 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r531440623 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala ## @@ -51,32 +54,35 @@ case class CacheTableCommand( if

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530763650 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala ## @@ -51,32 +54,35 @@ case class CacheTableCommand( if

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530762754 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropTableExec.scala ## @@ -27,7 +26,6 @@ import

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530762698 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ## @@ -471,8 +471,11 @@ class CatalogImpl(sparkSession:

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530652131 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala ## @@ -421,7 +421,7 @@ class CachedTableSuite extends QueryTest

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530571035 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala ## @@ -421,7 +421,7 @@ class CachedTableSuite extends QueryTest

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530606256 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala ## @@ -421,7 +421,7 @@ class CachedTableSuite extends QueryTest

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530606256 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala ## @@ -421,7 +421,7 @@ class CachedTableSuite extends QueryTest

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-25 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530571035 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala ## @@ -421,7 +421,7 @@ class CachedTableSuite extends QueryTest

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-24 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530121226 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -679,3 +679,30 @@ case class

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-24 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r530117606 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -679,3 +679,30 @@ case class

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-24 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r529273422 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -2018,28 +2021,32 @@ class DataSourceV2SQLSuite

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-24 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r529272864 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -710,6 +712,7 @@ class DataSourceV2SQLSuite

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-23 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r528907060 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CacheTableExec.scala ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-23 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r528907060 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CacheTableExec.scala ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-23 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r528907060 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CacheTableExec.scala ## @@ -0,0 +1,78 @@ +/* + * Licensed to the

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-22 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r528399664 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CacheTableExec.scala ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] [spark] imback82 commented on a change in pull request #30403: [SPARK-33448][SQL] Support CACHE/UNCACHE TABLE commands for v2 tables

2020-11-22 Thread GitBox
imback82 commented on a change in pull request #30403: URL: https://github.com/apache/spark/pull/30403#discussion_r528399639 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -3323,7 +3323,7 @@ class AstBuilder extends