[GitHub] [spark] itholic commented on pull request #42962: [SPARK-44033][PYTHON] Added support for binary ops for list like objects

2023-09-17 Thread via GitHub
itholic commented on PR #42962: URL: https://github.com/apache/spark/pull/42962#issuecomment-1722634015 Basically, could you do: - [ ] complete the PR description - [ ] Add a basic unit tests - [ ] Reformatting codes by running `./dev/reformat-python` -- This is an automated messa

[GitHub] [spark] itholic commented on pull request #42962: [SPARK-44033][PYTHON] Added support for binary ops for list like objects

2023-09-17 Thread via GitHub
itholic commented on PR #42962: URL: https://github.com/apache/spark/pull/42962#issuecomment-1722632813 Also let's reformat the Python codes. We can easily reformat by running `./dev/reformat-python` on the project root path. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] itholic commented on pull request #42962: [SPARK-44033][PYTHON] Added support for binary ops for list like objects

2023-09-17 Thread via GitHub
itholic commented on PR #42962: URL: https://github.com/apache/spark/pull/42962#issuecomment-1722632383 Let's fill the PR description and add a unit tests first to verify the if the function is working as expected. We can start with adding a very basic test into `python/pyspark/panda