[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-06-05 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1218169052 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala: ## @@ -30,21 +31,33 @@ import org.apache.commons.io.FileUtils import

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-06-04 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1216559940 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ## @@ -46,7 +46,14 @@ private[sql] class SparkResult[T](

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-04-19 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1171415246 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ## @@ -46,7 +46,13 @@ private[sql] class SparkResult[T](

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-04-19 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1171412580 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ## @@ -142,24 +150,41 @@ private[sql] class SparkResult[T]( /**

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-04-19 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1171412097 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala: ## @@ -863,6 +865,38 @@ class ClientE2ETestSuite extends

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-04-15 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1167475609 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ## @@ -45,7 +45,7 @@ private[sql] class SparkResult[T](

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-04-15 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1167475549 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ## @@ -134,24 +134,41 @@ private[sql] class SparkResult[T]( /**

[GitHub] [spark] ivoson commented on a diff in pull request #40610: [SPARK-42626][CONNECT] Add Destructive Iterator for SparkResult

2023-03-30 Thread via GitHub
ivoson commented on code in PR #40610: URL: https://github.com/apache/spark/pull/40610#discussion_r1154005920 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala: ## @@ -134,24 +134,41 @@ private[sql] class SparkResult[T]( /**