[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-16 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-511699348 Thanks for the fix, merging to master branch. ---

[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-15 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-511631843 To avoid some flaky tests, run jenkins again. Overall LGTM. -

[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-15 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-511631681 Jenkins, retest this please.

[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-15 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-511305228 Jenkins, retest this please.

[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-10 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-510022505 You can use some test file system to do the unit test, there's some exampl

[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-10 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-509988510 I'm OK with the current solution, but I think we should some unit tests to

[GitHub] [spark] jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first.

2019-07-01 Thread GitBox
jerryshao commented on issue #24909: [SPARK-28106][SQL] When Spark SQL use "add jar" , before add to SparkContext, check jar path exist first. URL: https://github.com/apache/spark/pull/24909#issuecomment-507493512 >Why I add a new API is to keep previous call stacks(core behavior,start