jiangxb1987 commented on a change in pull request #28476:
URL: https://github.com/apache/spark/pull/28476#discussion_r421973578
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -688,10 +688,11 @@ private[spark] class TaskSchedulerImpl(
val errorMsg =
s"Fail resource offers for barrier stage ${taskSet.stageId}
because only " +
s"${addressesWithDescs.size} out of a total number of
${taskSet.numTasks}" +
- s" tasks got resource offers. This happens because barrier
execution currently " +
- s"does not work gracefully with delay scheduling. We highly
recommend you to " +
- s"disable delay scheduling by setting spark.locality.wait=0 as
a workaround if " +
- s"you see this error frequently."
+ s" tasks got resource offers. This could happen if delay
scheduling or " +
+ s"blacklisting is enabled, as barrier execution currently does
not work " +
+ s"gracefully with them. We highly recommend you to disable
delay scheduling " +
+ s"by setting spark.locality.wait=0 or disable blacklisting by
setting " +
+ s"spark.blacklist.enabled=false as a workaround if you see
this error frequently."
Review comment:
You might also want to check whether blacklist is actually enabled here.
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -688,10 +688,11 @@ private[spark] class TaskSchedulerImpl(
val errorMsg =
s"Fail resource offers for barrier stage ${taskSet.stageId}
because only " +
s"${addressesWithDescs.size} out of a total number of
${taskSet.numTasks}" +
- s" tasks got resource offers. This happens because barrier
execution currently " +
- s"does not work gracefully with delay scheduling. We highly
recommend you to " +
- s"disable delay scheduling by setting spark.locality.wait=0 as
a workaround if " +
- s"you see this error frequently."
+ s" tasks got resource offers. This could happen if delay
scheduling or " +
+ s"blacklisting is enabled, as barrier execution currently does
not work " +
+ s"gracefully with them. We highly recommend you to disable
delay scheduling " +
+ s"by setting spark.locality.wait=0 or disable blacklisting by
setting " +
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
