karenfeng commented on a change in pull request #33560: URL: https://github.com/apache/spark/pull/33560#discussion_r681416650
########## File path: core/src/main/resources/error/README.md ########## @@ -79,16 +79,177 @@ The message format accepts string parameters via the C-style printf syntax. The quality of the error message should match the [guidelines](https://spark.apache.org/error-message-guidelines.html). -Invariants: +#### Invariants - Unique ### SQLSTATE SQLSTATE is an optional portable error identifier across SQL engines. For consistency, Spark only sets SQLSTATE as defined in the ANSI/ISO standard. -Spark does not define its own classes or subclasses. +SQLSTATE comprises a 2-character class value followed by a 3-character subclass value. +Spark only uses the standard-defined classes and subclasses, and does not use implementation-defined classes or subclasses. -Invariants: +#### Invariants - Consistent across releases + +#### ANSI/ISO standard + +The following SQLSTATEs are from ISO/IEC CD 9075-2. + +|SQLSTATE|Class|Condition |Subclass|Subcondition | +|--------|-----|------------------------------------------------------------|--------|---------------------------------------------------------------| +|07000 |07 |dynamic SQL error |000 |(no subclass) | Review comment: I don't particularly care either way. Given that this is pulled directly from the SQL manual and this is the style they went with, I'm ok with keeping it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
