[GitHub] [spark] karenfeng commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-27 Thread GitBox
karenfeng commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-849845128 @viirya - in the case that the number of references is `!=1`, should we exclude the `ExtractValue` from `nestedFieldReferences`? -- This is an automated message from the Apa

[GitHub] [spark] karenfeng commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-05-18 Thread GitBox
karenfeng commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-843511836 @cloud-fan and @viirya, could you take another look? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] karenfeng commented on pull request #32301: [SPARK-35194][SQL] Refactor nested column aliasing for readability

2021-04-28 Thread GitBox
karenfeng commented on pull request #32301: URL: https://github.com/apache/spark/pull/32301#issuecomment-828836408 @viirya, I refactored the code that you merged in #31966 to fix conflicts. Can you take a look? -- This is an automated message from the Apache Git Service. To respond to th